Conversation
Contributor
Reviewer's GuideUpdates GhostBSD theme- and settings-related ports to the 26.01.0 release, introduces a new ghostbsd-wallpapers26 port, adjusts dependencies and installation paths for desktop environments, and cleans up unused pkg-* helpers and plists. Flow diagram for updated installation paths of settings and wallpapers portsflowchart TD
subgraph Build_phase
A_fetch_sources[Fetch sources from GitHub]
B_no_build[No build phase for these ports]
end
A_fetch_sources --> B_no_build
subgraph Install_xfce_settings[ghostbsd-xfce-settings install]
C_mkdir_etc_xdg[Create directory PREFIX/etc/xdg]
D_copy_xfce_xdg[Copy WRKSRC/etc/xdg/* to PREFIX/etc/xdg]
end
B_no_build --> C_mkdir_etc_xdg --> D_copy_xfce_xdg
subgraph Install_wallpapers26[ghostbsd-wallpapers26 install]
E_mkdir_backgrounds[Create directory PREFIX/share/backgrounds/ghostbsd]
F_copy_jpg[Copy WRKSRC/*.jpg to share/backgrounds/ghostbsd]
G_mkdir_mate_props[Create directory PREFIX/share/mate-background-properties]
H_copy_xml[Copy ghostbsd.xml as ghostbsd26.xml into mate-background-properties]
end
B_no_build --> E_mkdir_backgrounds --> F_copy_jpg
F_copy_jpg --> G_mkdir_mate_props --> H_copy_xml
subgraph Install_greeter_settings[ghostbsd-slick-greeter-settings install]
I_mkdir_lightdm[Create directory PREFIX/etc/lightdm]
J_copy_slick_conf[Copy slick-greeter.conf to slick-greeter.conf.sample]
end
B_no_build --> I_mkdir_lightdm --> J_copy_slick_conf
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- In both ghostbsd-mate and ghostbsd-xfce meta ports, the RUN_DEPENDS entries still use the package name ghostbsd-wallpapers25 while pointing to x11-themes/ghostbsd-wallpapers26, which looks like a typo and should likely be updated to ghostbsd-wallpapers26>0 for consistency.
- For the new ghostbsd-wallpapers26 port, consider using the standard ${INSTALL_DATA} macro instead of raw ${CP} in do-install to ensure correct permissions and follow ports framework conventions.
- After removing the pkg-plist/pkg-install files (e.g., for ghostbsd-xfce-settings), verify that the port still has an explicit plist (PLIST or PLIST_FILES) or another mechanism to track installed files, since ghostbsd-xfce-settings currently installs into ${PREFIX}/etc/xdg without an obvious replacement plist definition.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In both ghostbsd-mate and ghostbsd-xfce meta ports, the RUN_DEPENDS entries still use the package name ghostbsd-wallpapers25 while pointing to x11-themes/ghostbsd-wallpapers26, which looks like a typo and should likely be updated to ghostbsd-wallpapers26>0 for consistency.
- For the new ghostbsd-wallpapers26 port, consider using the standard ${INSTALL_DATA} macro instead of raw ${CP} in do-install to ensure correct permissions and follow ports framework conventions.
- After removing the pkg-plist/pkg-install files (e.g., for ghostbsd-xfce-settings), verify that the port still has an explicit plist (PLIST or PLIST_FILES) or another mechanism to track installed files, since ghostbsd-xfce-settings currently installs into ${PREFIX}/etc/xdg without an obvious replacement plist definition.
## Individual Comments
### Comment 1
<location> `x11/ghostbsd-mate/Makefile:26` </location>
<code_context>
mate-dock-applet>0:x11/mate-dock-applet \
ghostbsd-mate-settings>0:x11/ghostbsd-mate-settings \
- ghostbsd-wallpapers25>0:x11-themes/ghostbsd-wallpapers25 \
+ ghostbsd-wallpapers25>0:x11-themes/ghostbsd-wallpapers26 \
ghostbsd-gtk-themes>0:x11-themes/ghostbsd-gtk-themes \
ghostbsd-fonts>0:x11-fonts/ghostbsd-fonts
</code_context>
<issue_to_address>
**issue (bug_risk):** RUN_DEPENDS mix wallpapers25 origin name with wallpapers26 port path
The dependency name still uses `ghostbsd-wallpapers25` while the origin points to `x11-themes/ghostbsd-wallpapers26`, so the package will be registered under the old name. This should likely be `ghostbsd-wallpapers26>0:x11-themes/ghostbsd-wallpapers26` to match the new port and avoid inconsistent dependency metadata.
</issue_to_address>
### Comment 2
<location> `x11/ghostbsd-xfce/Makefile:43` </location>
<code_context>
mate-dock-applet>0:x11/mate-dock-applet \
ghostbsd-mate-settings>0:x11/ghostbsd-mate-settings \
- ghostbsd-wallpapers25>0:x11-themes/ghostbsd-wallpapers25 \
+ ghostbsd-wallpapers25>0:x11-themes/ghostbsd-wallpapers26 \
ghostbsd-gtk-themes>0:x11-themes/ghostbsd-gtk-themes \
ghostbsd-fonts>0:x11-fonts/ghostbsd-fonts
</code_context>
<issue_to_address>
**issue (bug_risk):** Inconsistent wallpapers dependency name vs origin for XFCE meta-port
The dependency name `ghostbsd-wallpapers25` no longer matches the origin `x11-themes/ghostbsd-wallpapers26`, so the logical package name remains outdated while pulling in the new port. Please update it to `ghostbsd-wallpapers26>0:x11-themes/ghostbsd-wallpapers26` for consistency with the actual origin.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update GhostBSD desktop theme and settings ports for the 26.01 release and introduce a new 2026 wallpapers collection.
New Features:
Bug Fixes:
Enhancements: