-
-
Notifications
You must be signed in to change notification settings - Fork 118
Transition to wheel from sudo as the privileged group #7227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
tentatively marking as ready for review |
EbonJaeger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some more packages that need to be modified:
gvfsgnome-control-centercupsbluemanflatpakbudgie-control-centerbolt
|
Also needs a rebase for |
**Summary** - We wish to transition away from sudo as the wheel group
**Summary** - Resolves #7169, depends on admin users being in the wheel group
**Summary** - We're a wheel distro now
Thanks, added. I'd like to do another couple of online & offline upgrade tests with these to ensure nothing blows up due to the group changing underneath it but I think it should be fine. |
EbonJaeger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! At the very least, I want to hold off on merging this until the scheduled package server maintenance is completed. Do you want to do some more testing as well before this goes in?
Only if you find some time you'll willing to do it rather than it being a burden |
Summary
wheel is the default and sudo is a debianism from the solus 2 days. Requires us to patch things so they work as expected but invetiably we've missed some things over the years causing some functionality to not work as expected.
We will not yet remove admin users from the sudo group until we are confident we've found everything
Resolves #299, #7169.
Test Plan
Add packages to local repo, update and reboot
getent group wheelflatpak historynow works without sudo requried if part of the wheel groupjournalctlshows all the journal without sudo required if part of the wheel groupChecklist