ref(seer-rpc): type rpc_get_trace_waterfall return as EAPTrace | None#117779
Draft
azulus wants to merge 1 commit into
Draft
ref(seer-rpc): type rpc_get_trace_waterfall return as EAPTrace | None#117779azulus wants to merge 1 commit into
azulus wants to merge 1 commit into
Conversation
The function was already constructing a typed `EAPTrace` via the
underlying `get_trace_waterfall` helper, then calling `.dict()` to
flatten it for the RPC dispatcher. Drop the flatten and let the
dispatcher's BaseModel adapter serialize.
Wire shapes: byte-identical for the success path. The not-found path
returns `None` instead of `{}`; the known seer caller checks
`if not rpc_result`, which is falsy for both.
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function was already constructing a typed
EAPTracevia the underlyingget_trace_waterfallhelper, then calling.dict()to flatten it for the RPC dispatcher. Drop the flatten and let the dispatcher's BaseModel adapter serialize.Wire shapes: byte-identical for the success path. The not-found path returns
Noneinstead of{}; the known seer caller checksif not rpc_result, which is falsy for both.