fix: add buffer flusher for sentry handler - #936
Merged
Conversation
Litarnus
marked this pull request as ready for review
August 11, 2025 08:32
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Litarnus
marked this pull request as draft
August 11, 2025 16:15
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Lower PHPUnit minimum version from ^8.5.40 to ^8.5.21 - This ensures compatibility with PHP 7.2 lowest dependencies - Addresses GitHub Actions test failure for PHP 7.2 with Symfony 4.4.* lowest dependencies
…ed by other e2e tests
Litarnus
marked this pull request as ready for review
August 12, 2025 12:33
This was
linked to
issues
Aug 12, 2025
cleptric
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a buffer flush handler for the sentry monolog handler, which will make sure that the monolog buffers for sentry are flushed before other sentry services finish.
This makes sure that flushed events get augmented with proper breadcrumbs and request information.
Before the introduction of the Flusher, other listeners would finish a sentry transaction before flushing all buffered events, leading to potential loss of context information from the current scope.
Closes #908 & #763
Fixes: SYMFONY-12