feat(core): Pass normalizedRequest to the sampling context for root spans#21833
Merged
Conversation
…pans Forward the isolation scope's normalizedRequest into the tracesSampler sampling context for root spans, so sampling functions can decide based on the incoming request (url, method, query string). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
chargome
approved these changes
Jun 29, 2026
nicohrubec
approved these changes
Jun 29, 2026
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Forward the isolation scope's
normalizedRequestinto thetracesSamplersampling context for root spans._startRootSpannow includes it in the object passed to the sampler.Why
SamplingContextalready advertises anormalizedRequestfield, and server SDKs already record the incoming request on the isolation scope, but core never wired the two together for root spans, sotracesSampleralways receivednormalizedRequest: undefinedon the standard root-span path. This closes that gap so custom samplers can decide based on the incoming request (drop health-check routes, raise the rate for/api/*, key off the HTTP method) instead of reverse-engineering it from the span name or attributes, which for an incoming HTTP root span may not yet carry the route at sampling time.Extracted standalone from #21666 (the
SentryTracerProviderstack): it has no dependency on that work, ships on its own merits, and shrinks #21666's review surface.