Features: Delete dataset property#1743
Open
sadiqkhoja wants to merge 4 commits intogetodk:features/delete-datasets-and-propertiesfrom
Open
Features: Delete dataset property#1743sadiqkhoja wants to merge 4 commits intogetodk:features/delete-datasets-and-propertiesfrom
sadiqkhoja wants to merge 4 commits intogetodk:features/delete-datasets-and-propertiesfrom
Conversation
* feature getodk/central#1337: Delete dataset * PR Feedback
sadiqkhoja
force-pushed
the
features/delete-properties
branch
from
cdb88ac to
d33939d
Compare
sadiqkhoja
commented
Feb 2, 2026
Comment on lines
+98
to
+100
| // TODO: how to delete unpublished property? | ||
| // if all forms that create or update this property were never published and have been unlinked (or deleted?) | ||
| // then delete the property automatically? |
sadiqkhoja
commented
Feb 3, 2026
|
|
||
| await asAlice.delete('/v1/projects/1/datasets/people/properties/first_name') | ||
| .expect(200); | ||
| })); |
Contributor
Author
There was a problem hiding this comment.
add a test: delete the related Form
| await asAlice.delete('/v1/projects/1/datasets/trees/properties/height') | ||
| .expect(200); | ||
|
|
||
| const result = await asAlice.get('/v1/projects/1/datasets/trees/entities.csv') |
Contributor
Author
There was a problem hiding this comment.
add another test to assert response of single entity data + assert correct response of version/diff api
ktuite
force-pushed
the
features/delete-datasets-and-properties
branch
from
798c250 to
a2fae57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testand confirmed all checks still pass OR confirm CircleCI build passes