nao context: orders model description in dbt schema.yml is vague and was the subject of a manual edit request - #1
Open
Bl3f wants to merge 1 commit into
Open
Conversation
…was the subject of a manual edit request
A user opened a chat to change the dbt orders description, stating it "should be 'orders paid last month'". The current schema.yml description ("This table has basic information about orders, as well as some derived facts based on payments") is vague and does not state the grain, key, or that amount is already aggregated. The orders model is NOT filtered to last month, so "orders paid last month" would be factually wrong — but the recurring desire to edit this description signals the metadata is unclear and should be made precise.
Co-authored-by: nao <naoagent@getnao.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed by nao context recommendations.
Why: A user opened a chat to change the dbt orders description, stating it "should be 'orders paid last month'". The current schema.yml description ("This table has basic information about orders, as well as some derived facts based on payments") is vague and does not state the grain, key, or that amount is already aggregated. The orders model is NOT filtered to last month, so "orders paid last month" would be factually wrong — but the recurring desire to edit this description signals the metadata is unclear and should be made precise.
Fix: Clarify the orders model description in repos/dbt/models/schema.yml to state grain and revenue semantics, e.g. "One row per order (key: order_id).
amountis the total order value (AUD), already aggregated across all payment methods." Do not set it to "orders paid last month" since the model is not date-filtered; if a last-month-paid metric is needed, define it as a separate model/metric. Confirm the intended meaning with the user.Files changed:
getnao/jaffle_shop_duckdb:models/schema.yml(fromrepos/dbt/models/schema.yml)Review carefully — this change was drafted automatically from real usage signals.