Fix admin label fallback for regioned locales#11
Merged
Conversation
rhukster
added a commit
that referenced
this pull request
Jun 28, 2026
Member
|
Thanks for this, and for the thorough tests. I reproduced it on a clean Merged, and I added a CHANGELOG entry for the next release. Appreciate the clear write-up and the fix keeping the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
en->en-US.ru-RU,es-MX, and bareenfallback chains.This lets dual-target plugins keep normal short-code language files such as
ru.yaml/en.yamlunless they intentionally need region-specific translations.Testing
/usr/local/opt/php@8.3/bin/php -l classes/Api/Controllers/TranslatesAdminLabels.php/usr/local/opt/php@8.3/bin/php -l tests/Unit/Controllers/TranslatesAdminLabelsTest.php/usr/local/opt/php@8.3/bin/php vendor/phpunit/phpunit/phpunit --configuration phpunit.xml tests/Unit/Controllers/TranslatesAdminLabelsTest.phpGRAV_ROOT=/Users/artyom/domains/palagin2 /usr/local/opt/php@8.3/bin/php vendor/phpunit/phpunit/phpunit --configuration phpunit.xml tests/Unit/Controllers/TranslatesAdminLabelsTest.phpFull suite check:
GRAV_ROOT=/Users/artyom/domains/palagin2 /usr/local/opt/php@8.3/bin/php vendor/phpunit/phpunit/phpunit --configuration phpunit.xmlcurrently fails on the unchangeddevelopbaseline with 8 existing auth errors inApiKeyManagerand 1 existing CORS exposed-headers failure. The same failures reproduce after stashing this PR's changes.