Update Gradle wrapper to 9.2.1 and resolve pmd issues#114
Update Gradle wrapper to 9.2.1 and resolve pmd issues#114haroon-sheikh wants to merge 3 commits intomasterfrom
Conversation
|
@haroon-sheikh Thank you for contributing to gauge-gradle-plugin. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
Signed-off-by: Haroon Sheikh <[email protected]>
Signed-off-by: Haroon Sheikh <[email protected]>
Signed-off-by: Haroon Sheikh <[email protected]>
aae4d08 to
9787388
Compare
|
I spent a while reviewing this and changing to test across multiple (older) Gradle versions for backward compat in #119 , and discovered that there seems to be some problem with the windows tests (they are actually failing and have been for a while, but the PowerShell scripting in the build is incorrect and seemingly swallowing the failure) I couldn't work out why they are failing and the pattern is indiscernable (it's kinda like the 1st or 2nd integration test gets stuck or causes the runner to crash). Will probably refactor a bit to move this forward to be able to look at the windows issues separately though. |
|
Thanks @chadlwilson for looking into this.. I'd suggest we get this in as It should already be compatible with gradle v8 and v9 both. Testing with different gradle versions is a an overkill imho, as it should be up to the consumers to manage the version of Gradle wrapper. |
|
The problem is that if you don't specifically validate with different Gradle runtime versions there's really nothing to stop you consuming parts of the API which don't work in previous versions - since Gradle seemingly does not seem to allow you to build a plugin using newer Gradle while targeting an older API version in a binary safe way. |
This pull request updates the Gauge Gradle plugin to version 3.1.0 and introduces several improvements and cleanups to the plugin codebase and its tests. The most significant changes include updating dependencies and Gradle versions, refactoring code for clarity and maintainability, and improving test conventions.
Dependency and Version Updates:
README.md,build.gradleexample, andplugin/gradle.properties.gradle-wrapper.properties.Codebase Improvements and Refactoring:
AbstractGaugeTask,GaugeClasspathTask,GaugeTask,GaugeValidateTask) to usesuperfor setting group, description, and dependencies, and to pass descriptions via constructors for clarity.GaugeConstantsafinalclass and added a private constructor to prevent instantiation.GaugeCommandclass by removing unnecessary imports, streamlining flag logic, and usingtoList()instead ofCollectors.toList().GaugeExtensionfrom the class constructor to the plugin application logic inGaugePlugin, improving separation of concerns.Test and Example Code Improvements:
public), reordered imports, and improved code style for consistency.failOnNoDiscoveredTests = falsefor test tasks.Build Script and Wrapper Cleanup:
CLASSPATHassignments ingradlewandgradlew.batscripts.gradlew.These changes collectively modernize the plugin, improve maintainability, and ensure compatibility with the latest Gradle and Gauge versions.