[#219] Add support for AdminRules to Rest Batch services - [#221] Add RuleLimits handling to Rule REST endpoint#220
Open
taba90 wants to merge 3 commits intogeoserver:3.5.xfrom
Open
Conversation
taba90
force-pushed
the
219-multiple-rules-insertion
branch
from
9bc6165 to
db51edd
Compare
taba90
changed the title
taba90
force-pushed
the
219-multiple-rules-insertion
branch
from
db51edd to
e9ffad5
Compare
taba90
force-pushed
the
219-multiple-rules-insertion
branch
from
e9ffad5 to
648e2bf
Compare
taba90
changed the title
etj
approved these changes
Jul 18, 2022
etj
reviewed
Aug 29, 2022
| } | ||
|
|
||
| @Override | ||
| @Transactional(propagation = Propagation.REQUIRED, value = "geofenceTransactionManager") |
Member
There was a problem hiding this comment.
I would not remove the Transactional annotation here: there are many db calls and race conditions may disrupt the priority handling.
Contributor
Author
|
thanks for your review @etj. Your feedback have been applied |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.