Added toolchain to autodetect jdk#89
Open
joachimnielandt wants to merge 2 commits intogeonetwork:mainfrom
Open
Added toolchain to autodetect jdk#89joachimnielandt wants to merge 2 commits intogeonetwork:mainfrom
joachimnielandt wants to merge 2 commits intogeonetwork:mainfrom
Conversation
- is used to autodetect correct jdk - mirrored the setup of geonetwork which seemed to work fine for me
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some trouble when building locally, as javac wasn't detected properly. Only after setting my OS-wide Java to v11 it built successfully. I remembered Geonetwork used toolchains though, which I added here as well. Does that make sense in this context?
Took the opportunity to tidy up some whitespace issues as well...