Add support for using JSON Path in SimpleURL Harvester#9132
Open
tobias-hotz wants to merge 3 commits intogeonetwork:mainfrom
Open
Add support for using JSON Path in SimpleURL Harvester#9132tobias-hotz wants to merge 3 commits intogeonetwork:mainfrom
tobias-hotz wants to merge 3 commits intogeonetwork:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using JSON Paths to get the identifier of a record.
We currently harvest a datasource where the true uuid is hidden in an array, and a JSON Pointer is not sufficient to reliably find the UUID. With this PR, the default is still JSON Pointers, but you can also switch to JSON Paths using a simple drop down menu.
I've tested this locally to confirm it works for our usecase.
My first attempt was to attempt parsing as JSON Pointer, and if that fails, fall back to JSON Path parsing. But an invalid JSON Pointer that should just fail would in that case be interpreted as a JSON Path, which is not always wanted. Also, it is not very obvious to users that JSON Paths are possible. Additionally, we always need to parse twice, which causes additional runtime overhead. So I decided to just use an explicit dropdown.
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentationFunded by LGL BW