Skip to content

Conversation

@CMath04
Copy link
Contributor

@CMath04 CMath04 commented Dec 8, 2025

Summary

This PR removes the hardcoded searchParamsPerType configuration from the OnlineSrcDirective.js file and instead moves it as part of the <schema>/config/associated-panel/*.json schema configuration.
This also implements global filter configuration on the sibling relation type via the metadataStore.params value.

Example of dcat-ap/config/associated-panel/default.json:

{
  "config": {
    "display": "radio",
    "multilingualFields": [],
    "associatedResourcesTypes": [
      {
        "type": "siblings",
        "label": "linkToSibling",
        "config": {
          "sources": {
            "metadataStore": {
              // metadataStore.params was ignored for siblings type before
              "params": {
                "documentStandard": [
                  "dcat-ap"
                ],
                "isTemplate": "n"
              },
              // moved from hardcoded JS file
              "searchParamsPerType": {
                "catalog-*": {
                  "type": [
                    "catalog"
                  ]
                },
                "nextResource-*": {
                  "type": [
                    "dataset",
                    "service"
                  ]
                }
              }
            },
            "remoteurl": {
              "multiple": true
            }
          }
        }
      }
    ]
  }
}

Result:
chrome_lDbQKs8KUi

CC: @fxprunayre , @joachimnielandt

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants