Add Input event API #1630
Draft
Add Input event API #1630
+553
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
looks good, I would add mouse scroll wheel before controller inputs. not sure if CCMouseDispatcher works but even if it does it's probably better to go all in with system apis. |
- remove mouse move/scroll from raw input (caused lag) - handle ALL mouse buttons even if they overlap - few refactors
allows mods to edit values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2.2081 removed onGLFW callbacks, the only really viable way to get inputs is using the WndProc hook. Instead of having each mod hooking it, Geode will handle everything and provide events.
Events probably should work on all platforms (android, mac, ios), but I will leave the implementation details to someone who can test them (or try with a VM later).
Tested on Windows with Eclipse Menu