PB-1387: all API files as a package#1542
Merged
pakb merged 6 commits intofeat-PB-1383-pinia-storefrom Jan 7, 2026
Merged
Conversation
pakb
force-pushed
the
feat-PB-1387-api-as-module
branch
from
8a084fa to
dcbc219
Compare
pakb
force-pushed
the
feat-PB-1387-api-as-module
branch
from
dcbc219 to
d00e500
Compare
also moving there GPX/KML utils, and legacy param utils, as they are used by some API files
pakb
force-pushed
the
feat-PB-1387-api-as-module
branch
2 times, most recently
from
3bba59e to
bd39c66
Compare
Moving Vitest CLI "flags" found in package json files into the config itself
pakb
force-pushed
the
feat-PB-1387-api-as-module
branch
from
bd39c66 to
7af7374
Compare
and especially Vitest, as there is in v4.0.9+ a fix for the pooling of threads, which fails sporadically on the CI. Locking Vite in version v7.2.2, as upgrading further breaks the build with unplugin-dts. Unplugin-dts has been in the same "beta" version for the last 6 month, we should maybe look for an alternative if it stays like that too long
since switching to the version 1.2.0, the manifest for the PWA has slightly increased, reaching the limit of 5MB. I've pushed it to 7MB to keep the build from failing because of that.
pakb
force-pushed
the
feat-PB-1387-api-as-module
branch
from
cf7e0c2 to
6be25a2
Compare
schtibe
approved these changes
Jan 6, 2026
Contributor
schtibe
left a comment
schtibe
left a comment
There was a problem hiding this comment.
Packaging looks OK. I mostly pointed out some cases where the enum wasn't used anymore
| const distance = | ||
| BASE_OFFSET_DISTANCE + | ||
| (selectedFeatureType.value === EditableFeatureTypes.Measure ? MEASURE_ADDITIONAL_OFFSET : 0) | ||
| (selectedFeatureType.value === 'MEASURE' ? MEASURE_ADDITIONAL_OFFSET : 0) |
Contributor
There was a problem hiding this comment.
Is it intentional not to use the enum here?
| let selectedInteraction | ||
| switch (drawingStore.edit.featureType) { | ||
| case EditableFeatureTypes.Annotation: | ||
| case 'ANNOTATION': |
Contributor
There was a problem hiding this comment.
Same here, why not the enum from the package?
| */ | ||
| const isFeatureMarker = computed<boolean>( | ||
| () => drawingStore.feature.current?.featureType === EditableFeatureTypes.Marker | ||
| () => drawingStore.feature.current?.featureType === 'MARKER' |
| import { isOnlineMode } from '@/store/modules/drawing/utils/isOnlineMode' | ||
| import useLayersStore from '@/store/modules/layers' | ||
|
|
||
| const layersStore = useLayersStore() |
Contributor
There was a problem hiding this comment.
(Maybe the answer lies elsewhere so this would be a comment to myself :D) why don't we need this filtering anymore?
| textPlacement: TextPlacement.Top, | ||
| size: featureStyleUtils.MEDIUM, | ||
| color: featureStyleUtils.RED, | ||
| textPlacement: 'top', |
Contributor
There was a problem hiding this comment.
I think text_placement could also be used from @swissgeo/api
| return visibleLayers | ||
| return visibleLayers.filter((layer) => { | ||
| // we filter out any "drawing" layer that are currently edited (it will be loaded by the drawing module onto the map) | ||
| if (layer.type === LayerType.KML) { |
looks like it could fix the issue that is present on the CI with video recording (takes forever)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also moving there GPX/KML utils, and legacy param utils, as they are used by some API files
Test link