PB-1383: Typescript+Pinia migration #1420
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schtibe
force-pushed
the
feat-PB-1383-pinia-store
branch
5 times, most recently
from
69171a7 to
bdd5620
Compare
pakb
force-pushed
the
feat-PB-1383-pinia-store
branch
3 times, most recently
from
448f1a4 to
2393419
Compare
pakb
force-pushed
the
feat-PB-1383-pinia-store
branch
from
fc5442f to
639f478
Compare
sommerfe
force-pushed
the
feat-PB-1383-pinia-store
branch
2 times, most recently
from
a1cccff to
9e6d8d7
Compare
and update the license/version to match our first attempt at publishing some code to npmjs.com 🎉
PB-2064: Fix Import Tool File Test
…oiding re-injection
… better state consistency
no cy.wrap inside should block
A debounce was added to the setPreview action, rendering the test covering useless, only debouncing outside of tests
there are some issue with @geoblocks/mapfishprint not sharing the same instance of OpenLayers than the rest of the code, leading to some false negative with "instanceof" operator. It is testing against ol/style/Image and ol/style/Circle, but doesn't use the same reference than our code, leading to always false results. I've added a patch to the lib to fix that
and trying to share the same OL "code" throughout the code-base (when imported into the viewer package) Also changing vite aliases with a simpler way of aliasing '@' that isn't using a URL anymore.
I had some issue with important not being applied (being second in line), and after testing without the prefix it was working as intended (so no need to add complexity there)
creates more issue that it solves
PB-2064: print cypress test
start moving away from TS enum, as they bring some problem when dealing with serialization/deserialization, while literals do the same kind of job without this downside.
accept time dimensions that are not proper "timestamp" from WMTS capabilities parsing
using the store is unreliable on the CI (and even sometimes locally), maybe due to some race conditions with vector feature selection that I couldn't fix by waiting on event/route change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link