Skip to content

PB-1447: Improve tracing - #87

Merged
msom merged 6 commits into
developfrom
feat-PB-1447-tracing
Jan 20, 2026
Merged

PB-1447: Improve tracing#87
msom merged 6 commits into
developfrom
feat-PB-1447-tracing

Conversation

@msom

@msom msom commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

Adds some improvements regarding tracing from service-control and service-stac:

  • Adds a container to locally test tracing
  • Removes the elastic-opentelemetry package as this sometimes interferes with the dependencies of the instrumentation packages and should be anyway already installed globally with pipx
  • Adds a section to the README that documents sampling
  • Adds opentelemetry-instrumentation-logging for log correlation
  • Removes opentelemetry-instrumentation-requests as our code does not directly use requests
  • Adds flags to enable/disable the different instrumentations

Also updates the curl example in the README since localhost is no longer supported by validators.

@github-actions github-actions Bot added the feature New feature or enhancement label Jan 13, 2026
Comment thread docker-compose.yml
- AWS_SECRET_ACCESS_KEY=dummy123
- AWS_DEFAULT_REGION=wonderland

otel-collector:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is an argument to use jaeger instead of zipkin?
You don't need an extra step to configure a OTEL collector when you use jaeger?

https://github.com/geoadmin/service-wms/pull/728/files#r2707189580

@KeeTraxx KeeTraxx left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@msom
msom merged commit 549c89f into develop Jan 20, 2026
9 checks passed
@msom
msom deleted the feat-PB-1447-tracing branch January 20, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants