Conversation
PB-1954: implement otel instrumentation
ltshb
approved these changes
Feb 9, 2026
Update from master
Currently, the regex for preventing qrcoding URLs other than map.geo.admin can be bypassed, e.g. by map.geo.admin.ch.attacker.com, since the regex is too weak. Hence the regex was anchored to make sure, that the URL to be qrcoded is exactly map.geo.admin.ch, rather than checking, that the string is somewhere in the URL.
Using fullmatch() instead of match() only makes the service safer. This way, even if the regex is not anchored, map.geo.admin.ch.evil.com bypass trick will still be detected by the fullmatch and blocked. Otherwise the regex needs to be anchored.
…allback PB-2205: using re.fullmatch() instead if re.match()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add otel instrumentation and monkey patching