Build: clean up warnings across emulator cores#34
Open
mariovirgili wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up build warnings across multiple emulator cores while keeping the resulting firmware build successful.
The main changes are:
Moves -fno-rtti out of the global build_flags and applies it only to C++ compilation via scripts/warning_flags.py. This keeps the flash-saving RTTI removal for C++ code, while avoiding invalid -fno-rtti warnings on C files where the flag has no effect.
Adds targeted warning flags for C/C++ where appropriate, without broadly hiding unrelated compiler output.
Fixes missing or ambiguous declarations in several cores, including MSX, PCE, WS/WSC, VFS, and SNES.
Cleans up macro redefinition warnings in Genesis, GBC, SMS, and GX4000 code.
Fixes const-correctness and function pointer table typing issues in NGP and other legacy C code.
Adjusts SNES APU stub declarations so disabled-sound builds still expose the expected prototypes.
Replaces a fragile strncat() usage in shared save-path generation with bounded memcpy() plus explicit termination.