Apply splat to schema sets and path aliases without explicit select.#929
Merged
Apply splat to schema sets and path aliases without explicit select.#929
Conversation
00201cc to
691103a
Compare
4a7d92a to
f458874
Compare
msullivan
approved these changes
Sep 26, 2025
msullivan
approved these changes
Sep 26, 2025
Comment on lines
+202
to
+204
| elif isinstance(kwarg, _qb.BaseAlias) and issubclass( | ||
| kwarg.__gel_origin__, _qb.GelObjectTypeMetadata | ||
| ): |
Member
There was a problem hiding this comment.
I would try to merge these cases, instead of duplicating the bodies?
f458874 to
a903234
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #838
Ensures a splat is applied in the following cases:
Also ensures that splats are applied if such a case is used within another object's select.