Skip to content

Fix syncing unset property with default setting value to None instead of default.#910

Merged
dnwpark merged 3 commits intomasterfrom
prop-w-default
Sep 12, 2025
Merged

Fix syncing unset property with default setting value to None instead of default.#910
dnwpark merged 3 commits intomasterfrom
prop-w-default

Conversation

@dnwpark
Copy link
Contributor

@dnwpark dnwpark commented Sep 9, 2025

Given a schema:

type Az {
    multi val: int64 {
        default := {-1, -2, -3};
    };
};

The following code was failing its assertion:

with_unset = default.Az()
self.client.sync(with_unset)

assert with_unset.val == [-1, -2, -3]

@dnwpark dnwpark requested a review from msullivan September 9, 2025 22:10
@dnwpark dnwpark force-pushed the prop-w-default branch 2 times, most recently from 2e8665e to e24c6a8 Compare September 10, 2025 21:37
Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure but I would love if @1st1 looked too

@dnwpark dnwpark merged commit d0328e1 into master Sep 12, 2025
43 checks passed
@dnwpark dnwpark deleted the prop-w-default branch September 12, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants