Skip to content

feat(idea/vara-eth): introduce service for uploading codes#2443

Merged
osipov-mit merged 23 commits into
mainfrom
do-upload-code-service
May 18, 2026
Merged

feat(idea/vara-eth): introduce service for uploading codes#2443
osipov-mit merged 23 commits into
mainfrom
do-upload-code-service

Conversation

@osipov-mit
Copy link
Copy Markdown
Member

No description provided.

@osipov-mit osipov-mit added the D6-vara-eth-idea Vara.Eth Idea label Apr 20, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the upload-code-service, a serverless application for Vara.Eth code validation using AWS Lambda, DynamoDB, and SQS. It also refactors blob encoding logic and updates workspace dependencies. Key feedback includes addressing idempotency issues that prevent retries, fixing database field name inconsistencies, and ensuring WASM code is not deleted upon job failure. Security concerns regarding overly permissive IAM roles and error message leakage were noted, alongside recommendations to use HTTP transport instead of WebSockets and to remove unreachable code in the worker.

Comment thread idea/vara-eth/upload-code-service/src/handler.ts Outdated
Comment thread idea/vara-eth/upload-code-service/src/shared/db.ts
Comment thread idea/vara-eth/upload-code-service/src/shared/db.ts Outdated
Comment thread idea/vara-eth/upload-code-service/src/handler.ts Outdated
Comment thread idea/vara-eth/upload-code-service/scripts/setup-aws.sh Outdated
Comment thread idea/vara-eth/upload-code-service/src/handler.ts Outdated
Comment thread idea/vara-eth/upload-code-service/src/eth.ts Outdated
Comment thread idea/vara-eth/upload-code-service/src/worker.ts Outdated
@osipov-mit
Copy link
Copy Markdown
Member Author

/gemini review latest changes

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new serverless service, upload-code-service, designed to handle Vara.Eth code validation requests by serializing submissions through an SQS queue and updating job statuses in DynamoDB. It also includes several dependency updates across the repository. My review highlights critical security concerns regarding the handling of private keys in Lambda environment variables, as well as architectural improvements for the Ethereum client, including switching from WebSocket to HTTP transport and offloading transaction receipt waiting to improve worker efficiency. Additionally, I suggested a more robust approach for parsing the request body in the handler.

Comment thread idea/vara-eth/upload-code-service/scripts/setup-aws.sh Outdated
Comment thread idea/vara-eth/upload-code-service/src/eth.ts Outdated
Comment thread idea/vara-eth/upload-code-service/src/eth.ts
Comment thread idea/vara-eth/upload-code-service/src/handler.ts Outdated
@osipov-mit osipov-mit marked this pull request as draft April 21, 2026 18:09
@osipov-mit osipov-mit force-pushed the do-upload-code-service branch from d22c1e5 to db72529 Compare April 27, 2026 11:52
@osipov-mit osipov-mit force-pushed the do-upload-code-service branch from db72529 to bd3a1fb Compare April 27, 2026 11:53
@osipov-mit osipov-mit marked this pull request as ready for review May 4, 2026 08:31
@osipov-mit osipov-mit merged commit c4cfe6d into main May 18, 2026
14 checks passed
@osipov-mit osipov-mit deleted the do-upload-code-service branch May 18, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D6-vara-eth-idea Vara.Eth Idea

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants