GDCC/21- Handle path and file validation#27
Closed
qqmyers wants to merge 10 commits into
Closed
Conversation
This was referenced Jun 5, 2024
Closed
Merged
Member
Author
|
Closing in favor of #36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds checks for valid path and filenames, using regexes based on the rules reported by Dataverse in the server.log. With the PR, these potential errors are caught and the user is warned that disallowed chars will be replaced by _ if the highlighted files are actually selected for upload. That substitution is done if any such files are uploaded. Checks for existing files also handle this substitution, i.e. the check is to see if a file with the changed path/filename exists in the dataset (not just the original/not allowed versions with bad chars).
Closes #21
In addition to #21, these issues were seen at QDR and we've been testing with our (slight) variant (some styling changes).