fix on ReExec implementation for tsan under linux_arm environment#91
Open
OldChicken1 wants to merge 1 commit intogcc-mirror:masterfrom
Open
fix on ReExec implementation for tsan under linux_arm environment#91OldChicken1 wants to merge 1 commit intogcc-mirror:masterfrom
OldChicken1 wants to merge 1 commit intogcc-mirror:masterfrom
Conversation
|
This is a read-only mirror that is not managed by GCC developers. Pull requests in this read-only mirror will be ignored forever. If you wish to contribute to GCC please read: https://gcc.gnu.org/wiki/GettingStarted |
Contributor
|
This should be fixed upstream in LLVM, then GCC will pick it up from there. A pull request here won't achieve anything. It seems to me that using |
NinaRanns
pushed a commit
to NinaRanns/gcc
that referenced
this pull request
Mar 11, 2025
…p26-attr-tests Retiring contracts cpp26 attr tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently under linux arm platform, if ASLR is enabled, executable that is compiled and linked with tsan options will be set a maximum stack size instead of unlimited, and get reexecuted (because of a aarch patch, see details https://reviews.llvm.org/D18003) . And that will rename the process as exe. If multiple process run with tsan, then they will all be renamed as exe and the tsan reports are also named as exe.{pid}, which makes it hard to identify a specific process. So instead of executing the link to the executable("/proc/self/exe"), try to pass the original argv[0] to execve function. And this will make the process reexecuted with their original name.