Skip to content

Add player labels for normal form game visuals#834

Draft
edwardchalstrey1 wants to merge 2 commits intomasterfrom
fix/574
Draft

Add player labels for normal form game visuals#834
edwardchalstrey1 wants to merge 2 commits intomasterfrom
fix/574

Conversation

@edwardchalstrey1
Copy link
Copy Markdown
Member

@edwardchalstrey1 edwardchalstrey1 commented Mar 31, 2026

Issues closed by this PR

Description of the changes in this PR

This PR adds player labels to the printout of normal form games:

Screenshot 2026-03-31 at 11 10 32
  • Label should always be centred, based on the number of columns (no. of player strategies)
  • Updates the test to check labels exist

How to review this PR

  • Check the player labels look right in tutorial 1 once rtd renders it (screenshot above)

@edwardchalstrey1
Copy link
Copy Markdown
Member Author

How it looks in the docs:

Screenshot 2026-03-31 at 11 51 46

@tturocy
Copy link
Copy Markdown
Member

tturocy commented Mar 31, 2026

Immediate queries:

  • What's this doing with games with more than two players?
  • What about the LaTeX output? Should we add the same feature?

At the risk of scope creep there's a bunch of different ways we might output tables, and one of the problems we have right now is code duplication (as we discovered in the earlier PR #757). LaTeX and HTML tables have basically the same iteration just different output of symbols.

Does it make sense to refactor to support possibly different outputs? For example markdown tables could be another possibility - not that we do that right now but it would become very easy to add with the right abstraction.

But it might also just be too much?

@edwardchalstrey1
Copy link
Copy Markdown
Member Author

edwardchalstrey1 commented Apr 14, 2026

Things to change:

  • Common logic for html vs latex output
  • Consider structure for 3 player strategic form tables

@tturocy Will write up a separate issue that explains this better - might be two issues, for the 2 steps above, the first shouldn't change the output

Different styles for Ed's benefit

Screenshot 2026-04-14 at 14 45 37 Screenshot 2026-04-14 at 14 47 47

@edwardchalstrey1 edwardchalstrey1 marked this pull request as draft April 16, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add player labels to normal form game visual

2 participants