feat: Enable image rendering and enhanced document editing (#4)#6
Draft
feat: Enable image rendering and enhanced document editing (#4)#6
Conversation
…ge support - Fix EasyMDE toolbar icons using codicon via 'icon' property - Add codicon CSS to Light DOM for glyph rendering - Theme toolbar with VS Code variables (hover, separator) - Disable FontAwesome auto-download (CSP fix) - Remove blur-to-exit edit mode (prevents toolbar interaction) - Remove fullscreen and guide toolbar buttons - Unify styles across preview, editor, and EasyMDE preview: - Shared font-family, font-size, line-height - Matching heading sizes (h1-h6) - Matching list, table, code, blockquote, link, image styles - Selection highlight using --vscode-editor-selectionBackground - Table style matching VS Code standard (no header bg, no zebra rows) - Add syntax highlighting via highlight.js + marked-highlight (vs2015 theme) - Fix local image display: expand localResourceRoots to include document directory and workspace folders - Add image upload support via EasyMDE with base64 data URI - Add document-style-preview.md sample for style verification - Remove obsolete blur-on-tab-click regression test
f-y
changed the title
- Resolve conflicts in spreadsheet-document-view.ts: - Keep EasyMDE editor integration - Adopt _getFullContent(includeHeader) to exclude title from edit mode - Adopt simplified _extractTitleAndBody (title from component property) - Resolve CHANGELOG.md: add v1.2.1 release notes - Install easymde at root level for test runner module resolution - Update single-h1-docsheet-ui tests for Light DOM and EasyMDE - Update save tests for new title-handling behavior - All 1054 tests passing
- Remove webview-ui/node_modules/.vite/ file from git tracking - Change /node_modules/ to node_modules/ in .gitignore to cover all depths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
Summary
Enable image display in the Document tab and support image insertion in edit mode, along with comprehensive improvements to the document editing experience.
Changes
Image Support
localResourceRootsto include document directory and workspace folders for local image accessEasyMDE Editor Integration
iconproperty, bypassing FontAwesome)Document Styling Improvements
--vscode-font-family), font-size, line-height, and heading sizes--vscode-editor-selectionBackground)Syntax Highlighting
vs2015theme for VS Code dark mode compatibilityTesting & Samples
document-style-preview.mdfor visual style verificationKnown Issues
##) are reconstructed as#when entering edit mode (to be addressed in a separate issue)