Skip to content

Comments

Make sure that out of slice point display is restricted to the z dimension#342

Merged
cmalinmayor merged 1 commit intomainfrom
no_more_out_of_slice_in_time
Feb 20, 2026
Merged

Make sure that out of slice point display is restricted to the z dimension#342
cmalinmayor merged 1 commit intomainfrom
no_more_out_of_slice_in_time

Conversation

@AnniekStok
Copy link
Collaborator

Make another Points subclass that overwrites the out-of-slice display logic and restrict it to the last non-displayed dim. Use it for orthoviews and TrackPoints

Partial fix for #238

… logic and restrict it to the last non-displayed dim only. Use it for orthoviews and TrackPoints
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 71.21212% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.10%. Comparing base (815ab22) to head (7b6242e).

Files with missing lines Patch % Lines
...ker/data_views/views/layers/out_of_slice_points.py 67.79% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   86.35%   86.10%   -0.25%     
==========================================
  Files          51       52       +1     
  Lines        4244     4305      +61     
==========================================
+ Hits         3665     3707      +42     
- Misses        579      598      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@cmalinmayor cmalinmayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦷

@cmalinmayor cmalinmayor marked this pull request as ready for review February 20, 2026 14:49
@cmalinmayor cmalinmayor merged commit 4bdc866 into main Feb 20, 2026
19 checks passed
@cmalinmayor cmalinmayor deleted the no_more_out_of_slice_in_time branch February 20, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants