Skip to content

Conversation

@groutr
Copy link
Contributor

@groutr groutr commented Jan 20, 2026

Resolves a TypeError where int/float/str/bool care called on v and v is a 1D array of 1 element.

Addresses #582

@martindurant
Copy link
Member

martindurant commented Jan 20, 2026

Please update from main. I don't know how a syntax typo got in there!

(NM: did it for you :) )

@martindurant
Copy link
Member

The set of failing tests, all relying on custom codecs that don't work in zarr 3, could be gated to only run on zarr 2.

@groutr
Copy link
Contributor Author

groutr commented Jan 20, 2026

Should probably add a test where v is a 1D array with a single element.

@groutr
Copy link
Contributor Author

groutr commented Jan 21, 2026

The set of failing tests, all relying on custom codecs that don't work in zarr 3, could be gated to only run on zarr 2.

I'm not sure how to fix that.

@martindurant
Copy link
Member

OK, don't worry about it.

@martindurant martindurant merged commit 3cd5ddc into fsspec:main Jan 21, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants