Feature/dcw vae controls and fixes - #96
Open
FrancoCotter wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request introduces a comprehensive upgrade to the parameter mapping layers, frontend user interface, and backend CLI executors to align with the latest 78-dimensional parameters schema of the ACE-Step 1.5 core library, fully unlocking Dual Conditioning Wavelet (DCW) and VAE checkpoint customizability.
Key Changes
1. Align API with Latest 78-Dimensional Gradio Payload
server/src/services/acestep.tsfrom 51 slots to 78 slots (Index 0 to 77).track_nameandcomplete_track_classes.2. Enhanced Python CLI Fallback & Env Auto-Detection
.envenvironment loading insideserver/scripts/simple_generate.pyto respect system-level device and optimization overrides.acestep-5Hz-lm-4Bmodel alongside the original0.6Band1.7Bfiles.--vae-checkpoint,--dit-model,--no-dcw, and DCW scaling switches, allowing the CLI runner to perfectly match Gradio's state-driven logic.3. Data Flow Bug Fixes
complete_track_classeswas missing inside the UI generation dispatch (App.tsx) and backend API endpoint (server/src/routes/generate.ts), ensuring multitrack rendering functions exactly as intended.4. UI/UX Refinement & Layout Upgrades (
CreatePanel.tsx)Verification & Testing
--dit-model) and custom VAEs (--vae-checkpoint).