Fix(nightlife example app): Create an example of the nightlife take home project#422
Open
GJStathis wants to merge 3 commits intofreeCodeCamp:mainfrom
Open
Fix(nightlife example app): Create an example of the nightlife take home project#422GJStathis wants to merge 3 commits intofreeCodeCamp:mainfrom
GJStathis wants to merge 3 commits intofreeCodeCamp:mainfrom
Conversation
ShaunSHamilton
requested changes
Sep 4, 2023
Member
ShaunSHamilton
left a comment
There was a problem hiding this comment.
Hello there,
Thank you for taking the time to contribute.
We cannot accept this PR as is for a few reasons:
- The rollup config does not work
- It points to a file that does not exist
- The styling of the app does not fit the https://design-style-guide.freecodecamp.org/
- At the very least it should match the example video in the issue discussions
If you still want to work on this, let us know. Otherwise, someone else can take over this PR, or we can open a new one.
Thanks again 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #48950
Creation of nightlife take home project to use as example for coding interview prep section of website here
App implements all listed user stories.
One thing of note. I am not sure if the mobile view of the app is perfect. I did not know if I needed to optimize for all potential screens for this example or just desktop.
Finally, I do not know what the steps are to deploy this app past making this PR. Any help is appreciated.