feat: Complete the cycle for custom & standard Studio App builds#163
Open
ruchamahabal wants to merge 8 commits intodevelopfrom
Open
feat: Complete the cycle for custom & standard Studio App builds#163ruchamahabal wants to merge 8 commits intodevelopfrom
ruchamahabal wants to merge 8 commits intodevelopfrom
Conversation
standard app: `{frappe_app}/public/app_builds`, custom apps: `sites/{sitename}/files/app_builds`
- also hook exported studio app builds with frappe builds & custom studio app builds after migrate
- was using a relative path and generating builds in studio/frontend itself, use abs path instead
- merge implementations for `get_app_components`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
App-specific builds existed & studio used to only generate these on hitting publish. But the cycle was not complete.
Current State:
get_app_componentsfunction reads from DB (frappe.get_all("Studio Page", ...)), which doesn't work in a no-site bench build context for standard appsAfter
There are 2 types of apps one can create from Studio
Completing the build cycle to handle both these categories of builds
Closes #144, Closes #97