refactor(billing): Show payment failure in better way #6041
Draft
Bowrna wants to merge 1 commit intofrappe:developfrom
Draft
refactor(billing): Show payment failure in better way #6041Bowrna wants to merge 1 commit intofrappe:developfrom
Bowrna wants to merge 1 commit intofrappe:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6041 +/- ##
========================================
Coverage 73.04% 73.04%
========================================
Files 107 107
Lines 17219 17219
Branches 270 270
========================================
Hits 12577 12577
Misses 4619 4619
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show payment failure in better way for user to take action in UI. Currently its not actionable and doesn't convey urgency of issue. This code changes however doesn't look good in UI, so i will keep this changes in Draft mode and polish it with better design.