feat(deploy): Revamp deploy flow#5944
Merged
Aradhya-Tripathi merged 59 commits intodevelopfrom Apr 10, 2026
Merged
Conversation
…mination and bench terminations
…rver to get accurate number of create bench_docs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5944 +/- ##
===============================
===============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Remove a test,
Quite ambiguous in nature, we only throw validation error when it's a in-place update, otherwise we let sites, be empty press/press/press/doctype/bench_update/bench_update.py Lines 48 to 53 in e9947a7 Secondary this test was only passing since we also throw, the same validation error in; Line 770 in e9947a7 |
Better than patching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #5939
All the deployment flow is now marked in a single doctype, Managed by the Workflow Engine.
Internal steps are shown here as well
While the
Press Workflowis the execution brain, the state manager for deploy is theRelease PipelinedoctypeShould effectively get rid of long running transactions in the request cycle when a new deploy is created, allowing for instant deploy creations and avoiding random lock-wait timeout issues due to lock contention in long running transactions. Should also show the retry logic with a single source of truth
Release Pipelinedoctype which will not reach terminal state until all the retries (Build & Bench) have reached their individual terminal states.