Skip to content

feat: show reconciled/unreconciled indicator in list view#54176

Open
khushi8112 wants to merge 2 commits intofrappe:developfrom
khushi8112:payment-entry-list-reconciliation-indicator
Open

feat: show reconciled/unreconciled indicator in list view#54176
khushi8112 wants to merge 2 commits intofrappe:developfrom
khushi8112:payment-entry-list-reconciliation-indicator

Conversation

@khushi8112
Copy link
Copy Markdown
Member

@khushi8112 khushi8112 commented Apr 9, 2026

Before:
Screenshot 2026-04-09 at 6 19 33 PM

After:
Screenshot 2026-04-09 at 6 19 17 PM

Closes: #48261

no-docs

@khushi8112 khushi8112 requested a review from ruthra-kumar as a code owner April 9, 2026 12:37
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 1a82ce6c-b4de-4f18-ac01-81cd4e5600ee

📥 Commits

Reviewing files that changed from the base of the PR and between b0e3fa3 and a48a294.

📒 Files selected for processing (2)
  • erpnext/accounts/doctype/payment_entry/payment_entry_list.js
  • erpnext/public/js/utils/unreconcile.js

📝 Walkthrough

Walkthrough

The Payment Entry list view is enhanced with status indicators by adding fields for unallocated_amount and docstatus, along with a get_indicator function that displays different row statuses: cancelled (red) for docstatus 2, draft (orange) for docstatus 0, unreconciled (orange) for docstatus 1 with remaining balance, and reconciled (green) for docstatus 1 with zero balance. Additionally, the create_unreconcile_docs function is updated to accept a frm parameter and includes a callback that handles errors, reloads the form when applicable, and displays a success notification.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to evaluate if it relates to the changeset. Add a pull request description explaining the changes, their purpose, and any relevant context or testing information.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding reconciled/unreconciled status indicators to the Payment Entry list view.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In the payment entry list view, show entry is reconciled or unreconciled.

1 participant