Skip to content

fix: precision issue causing reconciliation error #54043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rtdany10 wants to merge 2 commits into
base: develop
Choose a base branch
from
+9 −2
Open

fix: precision issue causing reconciliation error #54043

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad48dfb
fix: precision issue causing reconciliation error
rtdany10 Apr 6, 2026
460cad8
chore: code styling changes
rtdany10 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,10 +798,17 @@ def get_journal_filter_conditions(self):


def reconcile_dr_cr_note(dr_cr_notes, company, active_dimensions=None):
allocated_amount_precision = get_field_precision(
frappe.get_meta("Payment Reconciliation Allocation").get_field("allocated_amount")
)
for inv in dr_cr_notes:
if (
abs(frappe.db.get_value(inv.voucher_type, inv.voucher_no, "outstanding_amount"))
< inv.allocated_amount
flt(
abs(frappe.db.get_value(inv.voucher_type, inv.voucher_no, "outstanding_amount"))
- inv.allocated_amount,
allocated_amount_precision,
)
< 0
):
frappe.throw(
_("{0} has been modified after you pulled it. Please pull it again.").format(inv.voucher_type)
Expand Down
Loading