You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Independent QA for PR #171 at exact head 0b3327031aadc6033efc95ef92ca3780f4c80ccd.
P0: none.
P1: FAIL - the resolver misses Cursor's documented $HOME/.cursor/bin install location and can instead launch an unrelated generic agent executable. resolve_launcher_command('cursor') searches ~/.local/bin/{cursor-agent,agent}, ~/bin/{cursor-agent,agent}, and system locations, but not ~/.cursor/bin/cursor-agent. build_start_command likewise exports only $HOME/.local/bin:$HOME/bin:$PATH. In an isolated reproduction with only ~/.cursor/bin/cursor-agent present, resolution returned bare cursor-agent and the generated PATH omitted ~/.cursor/bin, so a standard documented installation cannot start. The agent fallbacks are unsafe because that command is not provider-unique. Add provider-specific cursor-agent candidates for ~/.cursor/bin (and PATH support or an absolute resolved path), and do not fall back to unverified agent; cover these cases. Cursor's official GitHub Actions instructions explicitly add $HOME/.cursor/bin to PATH: https://docs.cursor.com/en/cli/github-actions
P2: the new tests do not cover cursor-cli or cursor-agent resolution, ~/.cursor/bin, generic-agent collision avoidance, full lifecycle/tmux injection, or the documented --mode/--trust pass-through.
Evidence:
Exact isolated detached checkout is clean and its parent diff contains exactly the three PR files; git diff --check HEAD^ HEAD passed.
Provider configuration correctly maps the three requested aliases, uses 3-second process-start readiness with empty prompt patterns, tmux-paste system-prompt fallback, runtime busy/blocked patterns, and shell-quoted launcher args. Manual command construction preserved --model, --mode ask, and --trust; CURSOR_API_KEY was absent from the command.
Focused provider/start/runtime suites: 34 passed.
Full suite: make test passed, 334 tests.
Exact-head CI is green: Quality Checks, Python 3.9/3.10/3.11/3.12, and Integration Matrix all SUCCESS.
Independent re-QA for PR #171 at exact head b972980a9df7677972374fdbae588fcd6dc709dc, superseding my prior FAIL.
P0: none.
P1: none.
P2: none.
Verified the prior P1 is closed:
resolve_launcher_command maps cursor, cursor-cli, and cursor-agent to provider-unique cursor-agent candidates only, with ~/.cursor/bin/cursor-agent first. No generic agent candidate remains.
Isolated contract reproduction for every alias: when both ~/.cursor/bin/cursor-agent and ~/.local/bin/agent exist, it resolves the former; with only generic agent, it fails closed to bare cursor-agent.
Generated command PATH includes $HOME/.cursor/bin:$HOME/.local/bin:$HOME/bin:$PATH; it preserves shell-quoted --model, --mode ask, and --trust, and does not include CURSOR_API_KEY.
Evidence: exact isolated detached checkout clean; changed scope is five files and git diff --check HEAD^ HEAD passes. Focused Cursor/start/Kimi/runtime suites: 26 passed. Full make test: 335 passed. Exact-head CI is SUCCESS for Quality Checks, Python 3.9/3.10/3.11/3.12, and Integration Matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cursorprovider resolving the officialcursor-agent/agentexecutableCloses #169
Verification
make lintpython3 -m unittest agent-manager/scripts/tests/test_provider_cursor.py -vpython3 -m unittest discover -s agent-manager/scripts/tests -p 'test_*.py'(334 tests, passed)git diff --checkNo external Cursor workspace was trusted and no repository mutation was performed by the smoke tests.