refactor(evm): DB generic instead of using lifetime-bound dyn trait#13949
Draft
mablr wants to merge 3 commits intofoundry-rs:masterfrom
Draft
refactor(evm): DB generic instead of using lifetime-bound dyn trait#13949mablr wants to merge 3 commits intofoundry-rs:masterfrom
DB generic instead of using lifetime-bound dyn trait#13949mablr wants to merge 3 commits intofoundry-rs:masterfrom
Conversation
Replace the `&'db mut dyn DatabaseExt` lifetime parameter with a generic `DB: Database<Error = DatabaseError> + Debug` bound across FoundryEvm, FoundryHandler, EthRevmEvm, and related functions. Call sites in backend/mod.rs and backend/cow.rs updated to explicitly coerce to `&mut dyn DatabaseExt` where needed.
mablr
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Replace the
&'db mut dyn DatabaseExtlifetime parameter with a genericDB: Database<Error = DatabaseError> + Debugbound acrossFoundryEvm,FoundryHandler,EthRevmEvm, and related functions. Making them perfectly aligned with alloy-evm patterns.Call sites in backend/mod.rs and backend/cow.rs updated to explicitly coerce to
&mut dyn DatabaseExtwhere needed.