refactor(script): dedup gas currency symbol lookup#13886
Open
joohhnnn wants to merge 2 commits intofoundry-rs:masterfrom
Open
refactor(script): dedup gas currency symbol lookup#13886joohhnnn wants to merge 2 commits intofoundry-rs:masterfrom
joohhnnn wants to merge 2 commits intofoundry-rs:masterfrom
Conversation
joohhnnn
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
zerosnacks
reviewed
Mar 27, 2026
Member
|
small merge conflict & nit; otherwise lgtm |
joohhnnn
force-pushed
the
script-gas-currency-symbol
branch
from
3f76801 to
d345402
Compare
Author
Fixed the conflict and nit :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing Tempo compatibility, found that
forge scriptdisplays "ETH" as the gas currency on Tempo (chain 4217), which uses USDC as its gas token.The fix is upstream in alloy-rs/chains#266, which adds
native_currency_symbol()for Tempo chains. Once that lands and alloy-chains is bumped, the existing.unwrap_or("ETH")fallback will correctly resolve to "USDC".This PR deduplicates the symbol lookup (repeated in simulate.rs, receipts.rs, broadcast.rs) into a shared
gas_currency_symbol()helper to keep things clean.Also found a separate issue — gas price estimates are inflated on Tempo (~41000 gwei vs actual 20 gwei). Filed as #13885