fix(anvil): guard zero prune history limit#13884
Open
mk0walsk wants to merge 1 commit intofoundry-rs:masterfrom
Open
fix(anvil): guard zero prune history limit#13884mk0walsk wants to merge 1 commit intofoundry-rs:masterfrom
mk0walsk wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Passing
--prune-history 0can propagate a zeromax_memory_historyintoInMemoryBlockStates, whereenforce_limitsloops onwhile self.present.len() >= self.in_memory_limit. With a zero limit, that condition never becomes false, which can leave Anvil stuck while pruning state history.Solution
Treat
0as an unsupported prune-history value at the config layer, and clamp in-memory cache limits to at least1in storage as a defensive fallback. This prevents the infinite eviction loop and adds regression tests for zero-value config parsing and cache initialization.PR Checklist