fix: support custom Etherscan URL in cast/forge commands#13333
Open
tefyosL-sol wants to merge 2 commits intofoundry-rs:masterfrom
Open
fix: support custom Etherscan URL in cast/forge commands#13333tefyosL-sol wants to merge 2 commits intofoundry-rs:masterfrom
tefyosL-sol wants to merge 2 commits intofoundry-rs:masterfrom
Conversation
tefyosL-sol
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
tefyosL-sol
force-pushed
the
fix/custom-etherscan-url
branch
from
bad7ab0 to
dc21f0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple commands (cast storage, cast creation-code, forge clone, etc.) were using Client::new() which ignores custom Etherscan URLs in config, changed to Client::builder() pattern to respect user configuration.