fix(config): prevent false warnings for valid vyper config keys#13317
Open
Himess wants to merge 1 commit intofoundry-rs:masterfrom
Open
fix(config): prevent false warnings for valid vyper config keys#13317Himess wants to merge 1 commit intofoundry-rs:masterfrom
Himess wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
When using inline table syntax for vyper configuration like:
```toml
[profile.default]
vyper = { optimize = "gas" }
```
The config system was incorrectly warning about `optimize` and
`experimental_codegen` being unknown keys.
This happened because `VyperConfig` uses `Option` fields with
`skip_serializing_if = "Option::is_none"`, which results in an empty
dict when serializing defaults. The warning system then had no
reference for valid keys.
Fix by adding explicit `VYPER_KEYS` constant as a fallback when the
default config produces an empty dict for a section.
Closes foundry-rs#13316
Himess
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13316