fix(forge): add browser wallet support for forge create#13301
Open
MarkFizz77 wants to merge 2 commits intofoundry-rs:masterfrom
Open
fix(forge): add browser wallet support for forge create#13301MarkFizz77 wants to merge 2 commits intofoundry-rs:masterfrom
MarkFizz77 wants to merge 2 commits intofoundry-rs:masterfrom
Conversation
MarkFizz77
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12958
forge create --browsernow works correctly. Previously it failed with "Use send_transaction_via_browser for browser wallets" error. The fix detects browser wallet signers and usessend_transaction_via_browser()instead of wrapping them inEthereumWallet.