chore(config): curl mode as config key#13260
Draft
mablr wants to merge 1 commit intofoundry-rs:masterfrom
Draft
Conversation
- Provide `--curl` consistently in all subcommands - Simplified helpers for provider instantiation using config - Adjusted the `signing_provider_with_curl` function to `get_provider_with_wallet` for consistency.
onbjerg
requested changes
Jan 29, 2026
Member
onbjerg
left a comment
There was a problem hiding this comment.
i dont want this as a config key, idt it makes sense to configure this overall. can we fix this in another way?
mablr
commented
Jan 29, 2026
Contributor
Author
There was a problem hiding this comment.
@onbjerg I see your point.
My goal was primarily to fix inconsistent handling of the --curl flag and secondarily to simplify logic before doing #13259.
Can we fix this in another way?
Another clean approach could consist of:
- Remove
curlfromRpcOpts - Introduce
CurlRpcOpts - Use
CurlRpcOptsinstead ofRpcOptsfor all subcommands to which we want to provide the--curlflag
#[derive(Clone, Debug, Default, Parser)]
#[command(next_help_heading = "Rpc options")]
pub struct CurlRpcOpts {
/// RPC options
#[command(flatten)]
pub url: RpcOpts,
/// Print the equivalent curl command instead of making the RPC request.
#[arg(long)]
pub curl: bool,
}
If you're okay with this proposition , i'll do first #13259 and then go back to this PR (as it's not anymore on my critical path)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Close #13252
Solution
--curlconsistently in all subcommandssigning_provider_with_curlfunction toget_provider_with_walletfor consistency.PR Checklist
--curl, no more implicit ignore)