chore(cheats): make sign(Wallet) pure

[DaniPopes]

Same as the equivalent fns without Wallet

[grandizzy]

@DaniPopes this should help to solve sepolia drpc flaky #12945

[DaniPopes]

theres an actual test failure but due to seed changing (?)

    Encountered 1 failing test in default/repros/Issue2851.t.sol:Issue2851Test
    [FAIL: <empty revert data>]
    	[Sequence] (original: 3, shrunk: 1)
    		sender=0x0000000000000000000000000000000000001DC0 addr=[default/repros/Issue2851.t.sol:Backdoor]0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f calldata=backdoor(uint256) args=[6912213124124532 [6.912e15]]
     invariantNotZero() (runs: 217, calls: 3255, reverts: 35)

what should i do @grandizzy ?

[grandizzy]

theres an actual test failure but due to seed changing (?)

    Encountered 1 failing test in default/repros/Issue2851.t.sol:Issue2851Test
    [FAIL: <empty revert data>]
    	[Sequence] (original: 3, shrunk: 1)
    		sender=0x0000000000000000000000000000000000001DC0 addr=[default/repros/Issue2851.t.sol:Backdoor]0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f calldata=backdoor(uint256) args=[6912213124124532 [6.912e15]]
     invariantNotZero() (runs: 217, calls: 3255, reverts: 35)

what should i do @grandizzy ?

checking, weird that it happens for win only ...

[grandizzy]

interesting seems we have this test twice, once here

foundry/crates/forge/tests/cli/test_cmd/repros.rs

Line 200 in af95ef4

function invariantNotZero() public {

and once in

foundry/testdata/default/repros/Issue2851.t.sol

Lines 25 to 30 in af95ef4

	/// forge-config: default.fuzz.dictionary.max_fuzz_dictionary_literals = 0
	/// forge-config: default.fuzz.seed = '111'
	function invariantNotZero() public {
	assertEq(back.number(), 1);
	}
	}

(which if I am not wrong is the one that fails?)

[DaniPopes]

#12953