fix(verify): avoid building standard json input for vyper#12838
Open
SashaMalysehko wants to merge 1 commit intofoundry-rs:masterfrom
Open
fix(verify): avoid building standard json input for vyper#12838SashaMalysehko wants to merge 1 commit intofoundry-rs:masterfrom
SashaMalysehko wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
SashaMalysehko
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When verifying contracts via Etherscan using the standard-json provider, always constructed a StandardJsonCompilerInput and sanitized solc settings even when the target language was Vyper. For Vyper we then ignored this input and built a separate VyperInput, which adds unnecessary work and allocations on larger projects. This change detects the contract language first and only builds and normalizes the StandardJsonCompilerInput in the Solidity branch, leaving the Vyper path to construct only the Vyper input JSON as before.