fix(ui): improve About Us layout and adjust description styling#3129
Open
bhavjsh wants to merge 1 commit intofossasia:flutterfrom
Open
fix(ui): improve About Us layout and adjust description styling#3129bhavjsh wants to merge 1 commit intofossasia:flutterfrom
bhavjsh wants to merge 1 commit intofossasia:flutterfrom
Conversation
Contributor
Reviewer's GuideRefactors the About Us screen layout to use a left-aligned scrollable column with a bordered description card, tighter and consistent list tile styling, and prepares localization for a minor text tweak in the PSLab description. Class diagram for the updated AboutUsScreen structureclassDiagram
class AboutUsScreen {
+AboutUsScreen()
+createState() _AboutUsScreenState
}
class _AboutUsScreenState {
-String iconAboutUs
-List contactItems
+buildSectionTitle(String title) Widget
+build(BuildContext context) Widget
}
class GlobalFunctions {
+buildContactList(List items) Widget
}
AboutUsScreen --> _AboutUsScreenState : creates
_AboutUsScreenState --> GlobalFunctions : uses_buildContactList
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The hardcoded 'Loading...' string in the version
FutureBuilderbypasses localization; consider exposing a localized loading string viaAppLocalizationsinstead. - The container around
pslabDescriptionusesColors.whiteand a fixed grey border, which may not adapt well to dark themes; it would be more robust to derive these fromTheme.of(context).colorScheme.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The hardcoded 'Loading...' string in the version `FutureBuilder` bypasses localization; consider exposing a localized loading string via `AppLocalizations` instead.
- The container around `pslabDescription` uses `Colors.white` and a fixed grey border, which may not adapt well to dark themes; it would be more robust to derive these from `Theme.of(context).colorScheme`.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Build StatusBuild successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/23088348450/artifacts/5924454449. Screenshots |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







-1_instruments_screen.png?raw=true)
-2_nav_drawer.png?raw=true)
-3_accelerometer.png?raw=true)
-4_power_source.png?raw=true)
-5_multimeter.png?raw=true)
-6_wave_generator.png?raw=true)
-7_oscilloscope.png?raw=true)
Summary
This PR improves the layout of the About Us screen to enhance readability and match the design feedback.
Changes
Files Modified
Result
The About Us page now has a cleaner layout with improved text alignment and spacing.
Summary by Sourcery
Refine the About Us screen layout and styling for improved readability and alignment.
Enhancements: