Skip to content

fix(web): generate web launcher icons and update branding#3125

Open
bhavjsh wants to merge 1 commit intofossasia:flutterfrom
bhavjsh:fix/web-launcher-icons
Open

fix(web): generate web launcher icons and update branding#3125
bhavjsh wants to merge 1 commit intofossasia:flutterfrom
bhavjsh:fix/web-launcher-icons

Conversation

@bhavjsh
Copy link
Contributor

@bhavjsh bhavjsh commented Mar 10, 2026

Summary

Fixes the web launcher icon and removes default Flutter branding from the PSLab web application.

Changes

  • added web launcher icon generation configuration in pubspec.yaml
  • generated web favicon and icons using flutter_launcher_icons
  • updated web/index.html to replace default Flutter text with PSLab branding
  • updated web/manifest.json to replace default Flutter metadata with PSLab information
Screenshot (2555)

Summary by Sourcery

Update web app branding and configure cross-platform launcher icon generation.

New Features:

  • Enable generation of web launcher icons and favicons via flutter_launcher_icons for web, Windows, macOS, and Linux builds.

Enhancements:

  • Align web metadata, titles, and descriptions with PSLab branding in index.html and manifest.json.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 10, 2026

Reviewer's Guide

Adds multi-platform launcher icon generation (including web) and updates web metadata and branding from generic Flutter defaults to PSLab-specific values.

File-Level Changes

Change Details Files
Configure flutter_launcher_icons to also generate web and desktop platform icons using the existing app icon asset.
  • Extend flutter_launcher_icons section with web configuration including generation flag, shared image path, background color, and theme color.
  • Enable Windows icon generation with shared image path and explicit icon size.
  • Enable macOS and Linux icon generation, reusing the same icon asset for both.
pubspec.yaml
Update web HTML metadata and manifest to reflect PSLab branding instead of default Flutter text.
  • Change meta description and page title to use PSLab name and Pocket Science Lab description.
  • Adjust apple-mobile-web-app-title capitalization to PSLab branding.
  • Ensure flutter_bootstrap.js script tag formatting is consistent and remove extraneous whitespace at end of document.
  • Update web app manifest name, short_name, description, and background_color to PSLab-specific values while keeping existing theme color.
web/index.html
web/manifest.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The change in web/index.html removes indentation from the <script src="flutter_bootstrap.js" async></script> line; consider keeping the indentation consistent with the surrounding HTML for readability.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The change in `web/index.html` removes indentation from the `<script src="flutter_bootstrap.js" async></script>` line; consider keeping the indentation consistent with the surrounding HTML for readability.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Build Status

Build successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/22975168340/artifacts/5880026566.

Screenshots

Android Screenshots
iPhone Screenshots
iPad Screenshots

@bhavjsh bhavjsh force-pushed the fix/web-launcher-icons branch from bc07ef8 to 5ad17a5 Compare March 10, 2026 18:41
@bhavjsh bhavjsh force-pushed the fix/web-launcher-icons branch from 5ad17a5 to e6d33c4 Compare March 11, 2026 21:23
Copy link
Contributor

@rahul31124 rahul31124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants