fix: replace deprecated timezone "Asia/Calcutta" with "Asia/Kolkata" (#2538)#2745
Closed
Keerthana-webdev wants to merge 1 commit intofossasia:devfrom
Closed
fix: replace deprecated timezone "Asia/Calcutta" with "Asia/Kolkata" (#2538)#2745Keerthana-webdev wants to merge 1 commit intofossasia:devfrom
Keerthana-webdev wants to merge 1 commit intofossasia:devfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the event timezone choices in the initial base migration to use the modern IANA identifier "Asia/Kolkata" instead of the deprecated "Asia/Calcutta" while keeping the rest of the choices list unchanged. Entity relationship diagram for updated Event timezone choiceserDiagram
Event_before {
char_32 timezone
string choice_Asia_Calcutta
}
Event_after {
char_32 timezone
string choice_Asia_Kolkata
}
Event_before ||--|| Event_after : migrates_to
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Instead of editing
0001_initial.py, create a new schema/data migration that updates the timezone choices and safely maps any existingAsia/Calcuttarecords toAsia/Kolkatato avoid breaking existing databases or migrations. - The updated
choiceslist now contains('Asia/Kolkata', 'Asia/Kolkata')twice; please deduplicate this entry so the choices remain clean and unambiguous.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of editing `0001_initial.py`, create a new schema/data migration that updates the timezone choices and safely maps any existing `Asia/Calcutta` records to `Asia/Kolkata` to avoid breaking existing databases or migrations.
- The updated `choices` list now contains `('Asia/Kolkata', 'Asia/Kolkata')` twice; please deduplicate this entry so the choices remain clean and unambiguous.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2538
Description
The timezone label "Asia/Calcutta" is outdated and has been replaced with the correct and current timezone name "Asia/Kolkata".
Changes Made
Type of Change
Checklist
Summary by Sourcery
Bug Fixes: