fix: Unhandled ValueError during authentication#2118
Open
intelliking wants to merge 1 commit intofortra:masterfrom
Open
fix: Unhandled ValueError during authentication#2118intelliking wants to merge 1 commit intofortra:masterfrom
intelliking wants to merge 1 commit intofortra:masterfrom
Conversation
Author
|
Hi @anadrianmanrique. Could you please review my PR and share any feedback? thank you. |
anadrianmanrique
added
the
in review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2099
Problem
When SMB authentication fails due to incomplete server responses (network drops, timeouts), users see:
This error message doesn't indicate what failed or which field caused the issue.
Solution
Added exception handling to catch the ValueError and provide a clearer error message:
Changes
impacket/structure.py: Added try/except block for ASCII string parsing (3 lines)