Modified reg-key creation to assume persistent key creation with impacket-reg#2113
Open
masterDeus wants to merge 2 commits intofortra:masterfrom
Open
Modified reg-key creation to assume persistent key creation with impacket-reg#2113masterDeus wants to merge 2 commits intofortra:masterfrom
masterDeus wants to merge 2 commits intofortra:masterfrom
Conversation
…d be volatile, and changed the default behavior to instead create non-volatile keys
anadrianmanrique
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
When creating registry keys using impacket-reg, the default behavior is to create a registry key that is volatile and as such is deleted upon reboot. This is not specified in the documentation, and limits use of the tooling.
Change
A flag has been introduced to impacket-reg add functionality that when used specifies that the key created is to be volatile. An assumption has been made that users not specifying this flag desires a persistant key to be created. If this assumption is false, then switching the requirement around would be trivial